Revive sync #70
Revive sync #70
Conversation
|
State validation during sync is now complete, opened a new issue for signature validation: #74 |
core/batch.go
Outdated
| return err | ||
| } | ||
|
|
||
| if batch.Status != BATCH_BROADCASTED && batch.Status == BATCH_COMMITTED { |
There was a problem hiding this comment.
I think we can safely remove batch.Status != BATCH_BROADCASTED.
- When
batch.Status != BATCH_COMMITTEDthe whole condition evaluates false - when
batch.Status == BATCH_COMMITTED,batch.Status != BATCH_BROADCASTEDevaluates true, so the whole condition evaluates true too.
| if batch.Status != BATCH_BROADCASTED && batch.Status == BATCH_COMMITTED { | |
| if batch.Status == BATCH_COMMITTED { |
There was a problem hiding this comment.
Yeah I think your suggestion assumes that the status can be either BATCH_BROADCASTED or BATCH_COMMITTED while I was trying to protect from invalid status codes too, which I think is stupid🤐
| newRoot, err = bz.ProcessTx(currentRoot, *tx, fromStateProof, toStateProof) | ||
| if err != nil { | ||
| if txDBConn.Instance != nil { | ||
| txDBConn.Instance.Rollback() |
There was a problem hiding this comment.
What is rollbacked here?
There was a problem hiding this comment.
If processTx is invalid we can rollback the changes made while witness creation
| return | ||
| } | ||
| if txDBConn.Instance != nil { | ||
| txDBConn.Instance.Commit() |
There was a problem hiding this comment.
What insert or update is committed here?
There was a problem hiding this comment.
There are updates performed in GetTxVerificationData() via a MySQL transaction, we can rollback those updates if processTx is invalid.
| if isSyncing && err == ErrSignatureNotPresent { | ||
| continue |
There was a problem hiding this comment.
Does the continue here mean the line commitments = append(commitments, commitment) is skipped?
There was a problem hiding this comment.
No it goes there, it simply means that if we are syncing and tx.Sig is nil we don't have to bubble up error as that is expected. I do think this piece is smelly and should be refactored in the future.
| if err != nil { | ||
| return | ||
| } | ||
| // func (b *Bazooka) applyMassMigrationTx(sender, receiver []byte, tx Tx) (updatedSender, updatedReceiver []byte, err error) { |
There was a problem hiding this comment.
nitpick: For these areas of commented off code, it's fine to just remove them.
Fixes #31