Add golangci-lint to CI #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChihChengLiang
force-pushed
the
add-go-vet
branch
from
d5c0bec to
14cc565
Compare
ChihChengLiang
force-pushed
the
add-go-vet
branch
from
14cc565 to
1ea44fe
Compare
ChihChengLiang
force-pushed
the
add-go-vet
branch
from
1ea44fe to
4136a58
Compare
ChihChengLiang
commented
Nov 11, 2020
| @@ -326,7 +335,6 @@ func ProcessTxs(db DB, bz Bazooka, txs []Tx, isSyncing bool) (commitments []Comm | |||
| commitment := Commitment{Txs: txInCommitment, UpdatedRoot: newRoot, BatchType: tx.Type, AggregatedSignature: aggregatedSig.ToBytes()} | |||
| commitments = append(commitments, commitment) | |||
| } | |||
| currentRoot = newRoot | |||
There was a problem hiding this comment.
This line is an ineffectual assignment, but you might want to take a closer look to check if something is missing.
There was a problem hiding this comment.
This is true, thanks!
Comment on lines
+69
to
70
| //nolint:govet // will fix later in #76 | ||
| return *syncerService |
There was a problem hiding this comment.
Don't think I can fix this in the short run, created #76 for this.
There was a problem hiding this comment.
Sounds good, I know the issue, I should just move the wait group outside the struct.
ChihChengLiang
force-pushed
the
add-go-vet
branch
from
3e5fb9a to
ed0e9d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #65