Content updates #24
Content updates #24
Conversation
There can sometimes be a delay between installing a package that triggers applicable errata and applicability being calculated on the server. To avoid this race condition, this will make a number of attempts to fetch errata before failing the test.
The default for the --systemd option in podman is to use the default CMD for a container to detect whether systemd should be set to true. From testing this appears to be buggy and not to always work. By setting --systemd to always we force podman to run with systemd working inside the containers and avoid any potential issues with automatic detection.
| retries = 0 | ||
| while retries < 5: | ||
| retries += 1 |
There was a problem hiding this comment.
Isn't this equal to:
| retries = 0 | |
| while retries < 5: | |
| retries += 1 | |
| for attempt in range(5): |
| '--systemd', | ||
| 'always', |
There was a problem hiding this comment.
Does the default (autodetection) not work?
There was a problem hiding this comment.
I cannot seem to get it to reliably work.
There was a problem hiding this comment.
Hmm ok. I don't mind being explicit and it is something we need anyway. Just curious.
| '--volume', | ||
| '/dev/log:/dev/log', |
There was a problem hiding this comment.
Can't you make this a parameter somehow? Is this something we can declare in the Dockerfile?
There was a problem hiding this comment.
You can only define one half of the volume endpoint in the Dockerfile. I can make it a parameter via fixtures most likely if we feel strong enough about it. This work around is only needed for EL6, and being special as is I just felt documenting it was cleaner than legacy code around it (and you also need an EL7 host).
There was a problem hiding this comment.
Ah right, if the trick only works on an EL7 host I think a parameter might be too complex. You could use variables. We already depend on pytest-variables so if we want to support it, that would be the way to go. Documenting a setting in a YAML file is probably better than documenting a code change.
No description provided.