Add Linux Client tests #10
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
commented
Dec 3, 2020
Comment on lines
+17
to
+24
| host = testinfra.get_host(request.param) | ||
|
|
||
| subman = host.package("subscription-manager") | ||
| if not subman.is_installed: | ||
| print('Installing subscription-manager') | ||
| host.run('yum -y install subscription-manager') | ||
|
|
||
| return host |
There was a problem hiding this comment.
This is just an example. I also considered making it an explicit parameter on the CLI pytest invocation and spawn them on demand here so they wouldn't be reused between tests. That's probably a much cleaner implementation.
ekohl
commented
Dec 3, 2020
|
|
||
| ``` | ||
| podman run --rm --detach --label smoker-linux-client --name centos-7 centos:7 /sbin/init | ||
| podman run --rm --detach --label smoker-linux-client --name centos-8 centos:8 /sbin/init |
There was a problem hiding this comment.
I noticed that not all container images have systemd installed by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very basic version, but shows some general concepts. The goal is to allow discussion on how to replace the bats tests.