Make clear_cache safe if no completion file is set (#386)

If it returns nil, expand_path fails. It also replaces a file deletion race condition with an atomic remove.
theforeman · Jul 3, 2024 · d72facc · d72facc
1 parent 12d8edd
commit d72facc
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/lib/hammer_cli/utils.rb b/lib/hammer_cli/utils.rb
@@ -55,8 +55,9 @@ def self.tty?
   end
 
   def self.clear_cache
-    cache_file = File.expand_path(HammerCLI::Settings.get(:completion_cache_file))
-    File.delete(cache_file) if File.exist?(cache_file)
+    if (completion_file = HammerCLI::Settings.get(:completion_cache_file))
+      FileUtils.rm_f(File.expand_path(completion_file))
+    end
   end
 
   def self.interactive?