-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rubocop Foreman action #187
Merged
Merged
+599
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nofaralfasi
reviewed
Mar 10, 2024
nofaralfasi
reviewed
Mar 10, 2024
nofaralfasi
requested changes
Mar 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stejskalleos
force-pushed
the
ls/rubocop
branch
from
March 14, 2024 09:57
1a99bb2
to
768ae14
Compare
stejskalleos
force-pushed
the
ls/rubocop
branch
from
March 14, 2024 10:01
768ae14
to
18c3fa5
Compare
stejskalleos
force-pushed
the
ls/rubocop
branch
6 times, most recently
from
March 14, 2024 13:32
c8fb352
to
7616849
Compare
stejskalleos
force-pushed
the
ls/rubocop
branch
from
March 14, 2024 13:39
7616849
to
5b52e28
Compare
Finally the rubocop job is green. |
@chris1984 can you take a look? |
chris1984
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, feel free to merge @stejskalleos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.