Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rubocop Foreman action #187

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Conversation

stejskalleos
Copy link
Contributor

@stejskalleos stejskalleos commented Mar 8, 2024

No description provided.

Rakefile Outdated Show resolved Hide resolved
.rubocop_todo.yml Outdated Show resolved Hide resolved
Copy link

@nofaralfasi nofaralfasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stejskalleos stejskalleos force-pushed the ls/rubocop branch 6 times, most recently from c8fb352 to 7616849 Compare March 14, 2024 13:32
@stejskalleos
Copy link
Contributor Author

Finally the rubocop job is green.

@stejskalleos stejskalleos requested a review from chris1984 March 19, 2024 08:12
@stejskalleos
Copy link
Contributor Author

@chris1984 can you take a look?

Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, feel free to merge @stejskalleos

@stejskalleos stejskalleos merged commit ae36cec into theforeman:master Mar 20, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants