Fixes #37990 - Fix DNS conflict detection to handle both IPv4 and IPv…

…6 blanks
theforeman · Nov 12, 2024 · 54afc35 · 54afc35
1 parent 09559ad
commit 54afc35
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/app/models/concerns/orchestration/dns.rb b/app/models/concerns/orchestration/dns.rb
@@ -108,7 +108,7 @@ def pending_dns_record_changes?
   end
 
   def dns_conflict_detected?
-    return false if ip.blank? || hostname.blank?
+    return false if (ip.blank? && ip6.blank?) || hostname.blank?
     # can't validate anything if dont have an ip-address yet
     return false unless require_ip4_validation? || require_ip6_validation?
     # we should only alert on conflicts if overwrite mode is off