Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HTTP proxy policy setting for Template Sync #3409

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Add HTTP proxy policy setting for Template Sync #3409

wants to merge 7 commits into from

Conversation

asteflova
Copy link
Member

@asteflova asteflova commented Oct 31, 2024 •
edited
Loading

What changes are you introducing?

  • Adding a description for HTTP proxy policy, a new setting for template sync, to the template sync reference section
  • Adding a reference to the new functionality to an existing procedure for template sync

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

Documents theforeman/foreman_templates#191.

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.12/Katello 4.14 (Satellite 6.16)
  • Foreman 3.11/Katello 4.13
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • Foreman 3.6/Katello 4.8
  • Foreman 3.5/Katello 4.7 (Satellite 6.13; orcharhino 6.6/6.7)
  • We do not accept PRs for Foreman older than 3.5.

@asteflova asteflova added Waiting for code Requires merge of related code in another repository before it can be merged and removed Not yet reviewed labels Oct 31, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 31, 2024 •
edited
Loading

The PR preview for 1b2bc76 is available at theforeman-foreman-documentation-preview-pr-3409.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

@asteflova asteflova added the Needs tech review Requires a review from the technical perspective label Nov 5, 2024
@asteflova asteflova added the Needs style review Requires a review from docs style/grammar perspective label Nov 7, 2024
@asteflova
Copy link
Member Author

Dear writers, this PR is still in draft state because it's waiting for the code to be finalized and merged but it is already open for feedback from style review in case anyone wants to take a look.

adamlazik1
adamlazik1 approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@adamlazik1 adamlazik1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last detail and LGTM.

guides/common/modules/proc_synchronizing-templates-with-an-existing-repository.adoc Outdated Show resolved Hide resolved
@asteflova asteflova added tech review done No issues from the technical perspective and removed Needs tech review Requires a review from the technical perspective labels Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamlazik1 adamlazik1 adamlazik1 approved these changes

Assignees
No one assigned
Labels
Needs style review Requires a review from docs style/grammar perspective tech review done No issues from the technical perspective Waiting for code Requires merge of related code in another repository before it can be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asteflova @adamlazik1