Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add check for account existence before login and display error message if not found #133

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

thahulive
Copy link
Contributor

This feature introduces an option that allows the system to verify the existence of a user account before proceeding with the login process. The primary goal is to enhance security and user experience by ensuring that only existing accounts can attempt to log in.

Key Changes:

  • New Configuration Option: check_account_exists_before_login

    • This option can be enabled or disabled to control whether the system verifies account availability during the login process.
  • Error Handling:

    • If the account is not found, a message saying "Couldn’t find your account" will be displayed to the user.

Benefits:

  • Enhanced Security: Prevents login attempts with non-existent accounts.
  • Improved User Feedback: Provides clear feedback when an account is not found.

This feature provides flexibility for applications that require pre-login account validation and improves the overall user experience during authentication.

Note: Inspired by the account verification flow in Google login. 😉

thahulive and others added 3 commits September 27, 2024 10:40
…ce-before-login

feat: Add check for account existence before login and display error message if not found
@thahulive thahulive marked this pull request as ready for review September 27, 2024 05:25
Copy link
Contributor

@bobbyiliev bobbyiliev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think that this looks good! Tagging @tnylea for a second review

@bobbyiliev bobbyiliev requested a review from tnylea September 27, 2024 14:58
@tnylea tnylea changed the base branch from main to artisancorpsmain October 25, 2024 19:08
@tnylea tnylea merged commit 8c7a95d into thedevdojo:artisancorpsmain Oct 25, 2024
1 check passed
@tnylea
Copy link
Contributor

tnylea commented Oct 25, 2024

Thanks @thahulive for this PR. Looks excellent, thanks for the contribution.

And thanks @bobbyiliev for pinging me 😉

I've gone ahead and changed this to merge into a branch on the main repo this way we can confirm that the tests pass. Here is the new PR: #137

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants