Remove # from episode numbers in commit messages
#513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@changelogbot keeps show notes, transcripts, and other content up to date. It creates commit titles like `Add Changelog & Friends #46`. On changelog.com, referring to episodes like `Changelog & Friends #46` is no problem. GitHub, however, will autolink these episode references and think they are issue or PR numbers. For example, here's a commit (thechangelog/show-notes@076c238) referencing a PR that has nothing to do with the show notes being committed. This commit will update `lib/changelog/github/source.ex` to remove the leading `#` and avoid having GitHub autolink the episode numbers.
|
Works for me. @all-contributors please add @br3ndonland for code |
|
I couldn't determine any contributions to add, did you specify any contributions? I've put up a pull request to add @br3ndonland! 🎉 |
|
That's amazing attention to detail @br3ndonland 🤓 I love that you captured all the context that was needed to make approving this super straightforward. Will be giving this PR a shout in the next Kaizen: Thank you 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@changelogbot keeps show notes, transcripts, and other content up to date. It creates commit titles like
Add Changelog & Friends #46.On changelog.com, referring to episodes like
Changelog & Friends #46is no problem. GitHub, however, will autolink these episode references and think they are issue or PR numbers.For example, here's a commit (thechangelog/show-notes@076c238) referencing a PR that has nothing to do with the show notes being committed:
Changes
lib/changelog/github/source.exappears to be where the leading#is added.changelog.com/lib/changelog/github/source.ex
Line 27 in 6e82988
This PR will update
lib/changelog/github/source.exto remove the leading#and avoid having GitHub autolink the episode numbers.WDYT?
Did I fix the right thing?
Will this break other stuff I don't know about?