Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak workflows to avoid double builds on PRs #166

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

tristanlabelle
Copy link
Contributor

@tristanlabelle tristanlabelle commented Nov 12, 2024

I think we were running the build workflow for any branch pushed as well as PRs, which resulted in redundant builds (one for the PR, one for the push to its branch). With this change, PRs only run each build (SPM and CMake) once. Compare with any previous PR, such as #165.

@tristanlabelle tristanlabelle requested review from z2oh, jeffdav and a team November 12, 2024 11:38
@tristanlabelle tristanlabelle marked this pull request as ready for review November 12, 2024 11:38
@tristanlabelle tristanlabelle enabled auto-merge (squash) November 12, 2024 14:26
@tristanlabelle tristanlabelle merged commit 4d658fd into main Nov 12, 2024
2 checks passed
@tristanlabelle tristanlabelle deleted the tristan/workflows-avoid-double-build branch November 12, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants