Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Orientation method #133

Merged
merged 5 commits into from
Feb 27, 2024

Conversation

Squidonomics
Copy link
Contributor

Implements the following method:
/session/:sessionId/orientation

Copy link
Contributor

@tristanlabelle tristanlabelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution and sorry for the wait! I think there's a bug in the definition of the get request and we can improve the API shape a little.

Sources/WebDriver/Requests.swift Show resolved Hide resolved
Sources/WebDriver/Requests.swift Outdated Show resolved Hide resolved
Sources/WebDriver/Session.swift Outdated Show resolved Hide resolved
Sources/WebDriver/Session.swift Outdated Show resolved Hide resolved
Sources/WebDriver/Requests.swift Outdated Show resolved Hide resolved
Copy link
Contributor

@tristanlabelle tristanlabelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@tristanlabelle tristanlabelle merged commit eab3069 into thebrowsercompany:main Feb 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants