fix: Enum naming convention #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
approved these changes
Nov 27, 2023
|
Could you please add a test case for this @Squidonomics? It should be something simple as serializing and deserializing the type. |
Yeah no problem, I'll throw one in real quick |
compnerd
approved these changes
Nov 28, 2023
tristanlabelle
approved these changes
Nov 28, 2023
Squidonomics
force-pushed
the
squid/codable-fix
branch
2 times, most recently
from
204d060
to
11b42d5
Compare
Squidonomics
force-pushed
the
squid/codable-fix
branch
from
52cadae
to
1b415f6
Compare
|
Is this good to be merged in? @tristanlabelle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #128