Rename visa_rb key to rb
#645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll try to look at this soon. I vaguely remember that there was a reason why RB isn't just "rb" in the data. Not sure if this is still a problem or if I even remember correctly. I need to dig around and check. |
|
I think I figured out the reason why. If the key in the |
Casper-Guo
force-pushed
the
fix-legacy-colors
branch
from
737cea2 to
4b5eef6
Compare
Casper-Guo
commented
Oct 25, 2024
Casper-Guo
commented
Oct 25, 2024
|
I can address the test failure later if these changes look more agreeable to you |
theOehrly
approved these changes
Oct 27, 2024
|
I think everything is good now? |
theOehrly
pushed a commit
that referenced
this pull request
Oct 27, 2024
* Fix internal team name mismatch for "visa rb" * Reorder fuzzy matching logic * Add regression test for team_color * fix test failure caused by using incorrect team colors reference --------- Co-authored-by: theOehrly <[email protected]> (cherry picked from commit 958576e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #644
I am choosing to change the team colors dictionary rather than the team translate dictionary because
visa rbis not how the team is represented in the data