race_control_messages Lap _api.py #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the colum lap to race_control_messages
theOehrly
requested changes
Nov 7, 2023
There was a problem hiding this comment.
"Lap" needs to be added to the docstring as well.
Please add it to the list of possible attributes. It seems to be present all the time. But I can imagine messages like delayed start before the first lap that might not have it.
Apart from that, everything looks good.
|
I added to the docstring:
|
|
Looks good now. Thank you 👍 |
Casper-Guo
pushed a commit
to Casper-Guo/Fast-F1
that referenced
this pull request
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the colum lap to race_control_messages