Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update writer handling #119

Merged
merged 2 commits into from
May 26, 2024
Merged

Update writer handling #119

merged 2 commits into from
May 26, 2024

Conversation

theEvilReaper
Copy link
Owner

Proposed changes

The current usage of writers creates a new instance every time, which is not ideal. After evaluating various solutions, including static references and delegation constructs, we found that both approaches are effective, but delegation requires more effort.

This pull request introduces a class that maintains references to writers in a lazy context, eliminating the need for repeated instantiation.

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...

@theEvilReaper theEvilReaper added the enhancement New feature or request label May 26, 2024
@theEvilReaper theEvilReaper added this to the v1.0.0 milestone May 26, 2024
@theEvilReaper theEvilReaper self-assigned this May 26, 2024
@theEvilReaper theEvilReaper modified the milestone: v1.0.0 May 26, 2024
@theEvilReaper theEvilReaper merged commit 70a72b6 into develop May 26, 2024
4 checks passed
@theEvilReaper theEvilReaper deleted the feature/writerDelegate branch May 26, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants