Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test package #112

Merged
merged 7 commits into from
Apr 28, 2024
Merged

Improve test package #112

merged 7 commits into from
Apr 28, 2024

Conversation

theEvilReaper
Copy link
Owner

Proposed changes

The test package has grown over time, as mentioned in issue #108. This pull request overhauls the structure of each test class. The changes include better display names, deletion of duplicated tests, and some refactoring to use other functionalities from JUnit 5. Closes #108

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@theEvilReaper theEvilReaper added the enhancement New feature or request label Apr 28, 2024
@theEvilReaper theEvilReaper added this to the v1.0.0 milestone Apr 28, 2024
@theEvilReaper theEvilReaper merged commit 6ad9ade into develop Apr 28, 2024
3 checks passed
@theEvilReaper theEvilReaper deleted the feature/improveTests branch May 13, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Improve test package
2 participants