Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add jk60rgb #2358

Merged
merged 2 commits into from
Nov 16, 2024
Merged

add jk60rgb #2358

merged 2 commits into from
Nov 16, 2024

Conversation

alabahuy
Copy link
Contributor

@alabahuy alabahuy commented Oct 29, 2024

Description

add jk60 rgb support via

QMK Pull Request

qmk/qmk_firmware#24485

VIA Keymap Pull Request

the-via/qmk_userspace_via#17

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • VIA keymap is MERGED in VIA userspace master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have formatted the JSON file to have consistent formatting with the rest of the repository.
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

v3/jaykeeb/jk60rgb/jk60rgb.json Outdated Show resolved Hide resolved
@Cipulot Cipulot merged commit 636c6e1 into the-via:master Nov 16, 2024
2 checks passed
@alabahuy alabahuy deleted the jk60rgb branch November 16, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants