Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add archerkeyboard/desire65.json #2327

Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open

Add archerkeyboard/desire65.json #2327

wants to merge 32 commits into from

Conversation

akyp
Copy link

@akyp akyp commented Jul 31, 2024

Description

Add VIA support for new keyboard PCB desire65.

QMK Pull Request

qmk/qmk_firmware#23776

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have formatted the JSON file to have consistent formatting with the rest of the repository.
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@Cipulot
Copy link
Collaborator

Cipulot commented Oct 8, 2024

v3/archerkeyboard/desire65/desire65.json Outdated Show resolved Hide resolved
Comment on lines 12 to 14
"menus": [
"qmk_rgblight"
],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akyp This enables all animations, just making sure that it is what you want. It looks like QMK source only enables a handful and would require a custom menu to show the correct amount.

To have the correct options shown, you should add the custom menu RGB Light explicit declaration and only use the effects you have enabled by removing the unused ones from the option list: https://www.caniusevia.com/docs/built_in_menus#qmk_backlight_rgblight

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed and new JSON tested. Thanks for the reminder.

@Cipulot Cipulot added the needs work The PR needs fixes/ things need to be addressed label Oct 8, 2024
@akyp akyp requested a review from Cipulot October 8, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs work The PR needs fixes/ things need to be addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.