Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add linworks fave60 json #1854

Merged
merged 10 commits into from
Nov 5, 2023
Merged

add linworks fave60 json #1854

merged 10 commits into from
Nov 5, 2023

Conversation

duilchoi
Copy link
Contributor

@duilchoi duilchoi commented May 8, 2023 •
edited by Xelus22
Loading

add fave60 json

Description

hi.
i added linworks fave60 json.
please review.

QMK Pull Request

qmk/qmk_firmware#20796

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@duilchoi
add fave60 json
da830f1 
add fave60 json
@duilchoi duilchoi changed the title add fave60 json add linworks fave60 json May 8, 2023
@Xelus22
Copy link
Collaborator

Xelus22 commented May 13, 2023 •
edited
Loading

I have unchecked this, becuase it is NOT merged yet. Please update it when it is.
image

Xelus22
Xelus22 requested changes Sep 30, 2023
View reviewed changes
Copy link
Collaborator

@Xelus22 Xelus22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

a few keys are missing colouring

@duilchoi duilchoi requested a review from Xelus22 October 2, 2023 03:13
Xelus22
Xelus22 requested changes Oct 2, 2023
View reviewed changes
v3/linworks/fave60/fave60.json Outdated Show resolved Hide resolved
@duilchoi duilchoi requested a review from Xelus22 October 3, 2023 16:30
Xelus22
Xelus22 requested changes Oct 7, 2023
View reviewed changes
v3/linworks/fave60/fave60.json Outdated Show resolved Hide resolved
@duilchoi duilchoi requested a review from Xelus22 October 10, 2023 15:31
@duilchoi duilchoi requested a review from Xelus22 October 30, 2023 15:06
@Xelus22 Xelus22 merged commit 2569384 into the-via:master Nov 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duilchoi @Xelus22