Update engine with upstream changes 2024-05-31 #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
aaronfranke
commented
Jun 2, 2024
mirror-godot-app/ui/common/components/endless_scroll_flow_container.gd
Outdated
Show resolved
Hide resolved
caused by login, tested without the new if and it works fine but kept the if statement and added an error added await for login added minimum 1 element as it seemed wise
RevoluPowered
approved these changes
Jun 4, 2024
|
Tested / Fixed minor scroll container bug. Weapon firing time is now from 5 seconds to 0.5 seconds on the first fire of the gun. Feels much more smooth on macbook requires wider testing and feels fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates The Mirror's engine fork to be based on commit
705b7a0b0bd535c95e4e8fb439f3d84b3fb4f427from 2024-05-31. This is about 2-3 months of upstream changes, and now this is Godot 4.3 beta instead of 4.3 dev. The commit that includes all of The Mirror's engine changes is5b3e2045d42a19a979c1357633ea0c350cbc3b60, which is what theproject.godotfile has the hash set to. As usual, this is the head ofthemirror.I tested the basics, opening the app, logging in, joining a space, opening both a GDScript and a visual script in the editor, and executing script code. Overall things are pretty smooth sailing. As for changes to the app, one GraphEdit behavior change, one unknown problem with
fetch_callable, and of course I reimported all files.