-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GDScript: Fix Inspector "Add Input" button, improve tweening, add print in chat, fix entry signals, add export vars #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Kluskey
reviewed
May 21, 2024
mirror-godot-app/creator/selection/inspector/script/inspector_script_entry_inputs.gd
Outdated
Show resolved
Hide resolved
Kluskey
reviewed
May 21, 2024
Kluskey
reviewed
May 21, 2024
aaronfranke
force-pushed
the
gdscript-insp-input-tween
branch
from
May 21, 2024 16:09
9e1dbc6
to
df01c85
Compare
aaronfranke
changed the title
GDScript: Fix Inspector "Add Input" button, improve tweening and add print in chat
GDScript: Fix Inspector "Add Input" button, improve tweening, add print in chat
May 21, 2024
aaronfranke
force-pushed
the
gdscript-insp-input-tween
branch
from
May 21, 2024 16:25
df01c85
to
9bddfc9
Compare
aaronfranke
changed the title
GDScript: Fix Inspector "Add Input" button, improve tweening, add print in chat
GDScript: Fix Inspector "Add Input" button, improve tweening, add print in chat, fix entry signals, add export vars
May 22, 2024
aaronfranke
force-pushed
the
gdscript-insp-input-tween
branch
from
May 22, 2024 03:29
6345613
to
21df857
Compare
Kluskey
reviewed
May 22, 2024
RevoluPowered
approved these changes
May 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit: Improve tweening and add print in chat
Second commit: Fix Inspector "Add Input" button
create_inspector_paramter_input
that is overridden for GDScript and visual scripting separately.connect_entry_signal
that can handle the case of connecting the signal with bindings.set_inspector_parameter_input_value
(no functionality change).Third commit: Fix custom entry signal creation dialog.
Fourth commit: Sync exposed
@export
vars with SpaceObject space varsthing = myvalue
won't work, instead one of these options must be used:set_object_variable(thing, myvalue)
thing = myvalue
followed bysave_exposed_vars.emit()
(plus there is alsoload_exposed_vars.emit()
if you want to read the space vars back into the script vars, this might be useful for sharing data between scripts).Fifth commit: Add a UI for updating export vars.