Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDScript: Fix Inspector "Add Input" button, improve tweening, add print in chat, fix entry signals, add export vars #184

Merged
merged 5 commits into from
May 30, 2024

Conversation

aaronfranke
Copy link
Contributor

@aaronfranke aaronfranke commented May 21, 2024

First commit: Improve tweening and add print in chat

  • Add GDScript object property tween.
  • Make trans/easing optional in GDScript.
  • Add a helper method for printing to chat in GDScript.
  • Add a helper method for getting the friendly name in GDScript.

Second commit: Fix Inspector "Add Input" button

  • It used to be hard-coded for visual scripting in the inspector, now there is a method create_inspector_paramter_input that is overridden for GDScript and visual scripting separately.
  • Previously the GDScript code only did a trivial signal connection, now there is a new method connect_entry_signal that can handle the case of connecting the signal with bindings.
  • New helper method set_inspector_parameter_input_value (no functionality change).
  • Also thrown in: Update the script template comment to encourage Notify.info instead of print.

Third commit: Fix custom entry signal creation dialog.

Fourth commit: Sync exposed @export vars with SpaceObject space vars

  • Now @export vars are saved as space vars, and space vars with a name matching the @export var are loaded in.
  • To update the var, thing = myvalue won't work, instead one of these options must be used:
    • set_object_variable(thing, myvalue)
    • thing = myvalue followed by save_exposed_vars.emit() (plus there is also load_exposed_vars.emit() if you want to read the space vars back into the script vars, this might be useful for sharing data between scripts).
  • In both cases, both the thing script var and the thing space variable on the object are updated. Users can use whatever workflow they prefer.

Fifth commit: Add a UI for updating export vars.
Screenshot 2024-05-21 at 8 28 55 PM

Copy link

vercel bot commented May 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
mirror-docs ⬜️ Ignored (Inspect) Visit Preview May 22, 2024 3:29am

@Kluskey Kluskey requested a review from RevoluPowered May 21, 2024 16:06
@aaronfranke aaronfranke force-pushed the gdscript-insp-input-tween branch from 9e1dbc6 to df01c85 Compare May 21, 2024 16:09
@aaronfranke aaronfranke changed the title GDScript: Fix Inspector "Add Input" button, improve tweening and add print in chat GDScript: Fix Inspector "Add Input" button, improve tweening, add print in chat May 21, 2024
@aaronfranke aaronfranke force-pushed the gdscript-insp-input-tween branch from df01c85 to 9bddfc9 Compare May 21, 2024 16:25
@aaronfranke aaronfranke changed the title GDScript: Fix Inspector "Add Input" button, improve tweening, add print in chat GDScript: Fix Inspector "Add Input" button, improve tweening, add print in chat, fix entry signals, add export vars May 22, 2024
@aaronfranke aaronfranke force-pushed the gdscript-insp-input-tween branch from 6345613 to 21df857 Compare May 22, 2024 03:29
Copy link
Collaborator

@RevoluPowered RevoluPowered left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RevoluPowered RevoluPowered merged commit 9273b4c into dev May 30, 2024
8 checks passed
@RevoluPowered RevoluPowered deleted the gdscript-insp-input-tween branch May 30, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants