Skip to content

Commit

Permalink
Fix viewing space causing assertion (#64)
Browse files Browse the repository at this point in the history
* Fix viewing space causing assertion

Why:
- _space.creator can be a dictionary or a string id. We must deal with both cases for now.

* Fix format

* Do not populate creator
  • Loading branch information
RevoluPowered authored Mar 26, 2024
1 parent 664c6e6 commit 29d0468
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions mirror-godot-app/scripts/net/space_client.gd
Original file line number Diff line number Diff line change
Expand Up @@ -50,19 +50,19 @@ func kick_me_from_spaces(space_id: String) -> Promise:

## Gets the most popular spaces.
func get_popular_spaces() -> Promise:
var extras: String = "populateCreator=true"
var extras: String = "populateCreator=false"
return self.get_request(GET_POPULAR, "/space/popular?%s" % extras)


## Gets the most popular spaces.
func get_favorites_spaces() -> Promise:
var extras: String = "populateCreator=true"
var extras: String = "populateCreator=false"
return self.get_request(GET_FAVORITES, "/space/favorites?%s" % extras)


## Gets the most popular spaces.
func get_recent_spaces() -> Promise:
var extras: String = "populateCreator=true"
var extras: String = "populateCreator=false"
return self.get_request(GET_RECENTS, "/space/recents?%s" % extras)


Expand Down

0 comments on commit 29d0468

Please sign in to comment.