Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support @interfaceObject (#38) #52

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Support @interfaceObject (#38) #52

merged 2 commits into from
Mar 15, 2024

Conversation

kamilkisiela
Copy link
Member

@kamilkisiela kamilkisiela commented Feb 27, 2024

Closes #7

This should close #7

The code is dirty... but it seems to be working 

**leftovers**
- [x] there are some global tests failing... I need to check and address
those.

---------

Co-authored-by: Troy Kohler <[email protected]>
@kamilkisiela kamilkisiela changed the title Interface object implementation (#38) Support @interfaceObject (#38) Mar 15, 2024
Copy link
Contributor

github-actions bot commented Mar 15, 2024

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@theguild/federation-composition 0.11.0-alpha-20240315143034-b9390e9 npm ↗︎ unpkg ↗︎

@kamilkisiela kamilkisiela merged commit 589effd into main Mar 15, 2024
4 checks passed
@kamilkisiela kamilkisiela deleted the interface-object branch March 15, 2024 14:37
kamilkisiela pushed a commit that referenced this pull request Mar 15, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @theguild/[email protected]

### Minor Changes

- [#52](#52)
[`589effd`](589effd)
Thanks [@kamilkisiela](https://github.com/kamilkisiela)! - Support
@interfaceObject directive

### Patch Changes

- [#52](#52)
[`589effd`](589effd)
Thanks [@kamilkisiela](https://github.com/kamilkisiela)! - Improve
INTERFACE_KEY_MISSING_IMPLEMENTATION_TYPE

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support @interfaceObject
2 participants