Start fixing phpstan fails #2002
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per https://theeventscalendar.atlassian.net/browse/TECENG-44 Fix issue with undefined `$container`
stratease
requested changes
Nov 1, 2023
Yeah, had to add the |
Fixes:
Invalid param formats in docblocks.
src/Tribe/Context.php
Invalid return statements:
Tribe__Admin__Notices::register_transient()
Tribe__Ajax__Dropdown::sort_terms_hierarchically()
Tribe__Admin__Notice__Plugin_Upgrade_Notice::parse_for_upgrade_notice()
Unsafe usage of new static()
Thrown in src/Common/Site_Health/Fields/Generic_Info_Field.php
mitigated via an interface to enforce the constructor signature
Static access to instance property Tribe\Admin\Upsell_Notice\Main::$template.
Incorrect/unused use function in src/Tribe/Admin/Notices.php
Camwyn
commented
Nov 14, 2023
phpstan.neon
Outdated
There was a problem hiding this comment.
Not sure why this shows as empty?
|
This PR has become the "fix" branch, see #2012 for the base "just add phpstan testing to TCMN" |
stratease
requested changes
Dec 22, 2023
| * @param array<string,string>|string|null $value | ||
| * @param int $priority | ||
| */ | ||
| public function __construct( string $id, string $label, $value = null, int $priority = 50 ); |
There was a problem hiding this comment.
Suggested change
| public function __construct( string $id, string $label, $value = null, int $priority = 50 ); | |
| public function __construct( string $id, string $label, $value = null, int $priority = 50 ); |
Am I seeing this correct? Spacing ok?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per https://theeventscalendar.atlassian.net/browse/TECENG-44
Fix issue with undefined
$containerAddress some of the things
phpstanis surfacing.