generated from the-collab-lab/smart-shopping-list
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 5. Add Items to list #20
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f49ce05
edit ManageList.jsx
jaguilar89 0f24cac
finished form on manage list view, refactored addItem function to sav…
sillytsundere e32236d
removed comment
sillytsundere 854f7b8
enhance accessibility and fixform submission requirements
rachelspencer 667147e
refactored code, simplified hooks into one handleSubmit hook, useStat…
sillytsundere 4160494
made suggested changes to ManageList.jsx
jaguilar89 078f475
added suggested changes to ManageList.jsx; made null the initial valu…
jaguilar89 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,79 @@ | ||
export function ManageList() { | ||
import { addItem } from '../api/firebase'; | ||
import { useRef } from 'react'; | ||
|
||
export function ManageList({ listPath }) { | ||
const formRef = useRef(null); | ||
|
||
const handleSubmit = async (e) => { | ||
e.preventDefault(); | ||
|
||
const formData = new FormData(e.target); | ||
const itemName = formData.get('itemName'); | ||
const daysUntilNextPurchase = parseInt( | ||
formData.get('daysUntilNextPurchase'), | ||
); | ||
|
||
try { | ||
await addItem(listPath, { | ||
itemName, | ||
daysUntilNextPurchase, | ||
}); | ||
|
||
alert('Item saved successfully'); | ||
formRef.current.reset(); | ||
} catch (error) { | ||
alert(`There was a problem: ${error.message}`); | ||
} | ||
}; | ||
|
||
return ( | ||
<p> | ||
Hello from the <code>/manage-list</code> page! | ||
</p> | ||
<form ref={formRef} onSubmit={handleSubmit}> | ||
<div> | ||
<label htmlFor="item">Item Name</label> | ||
<input name="itemName" type="text" id="item" required /> | ||
</div> | ||
|
||
<div> | ||
<label htmlFor="daysUntilNextPurchase"> | ||
How soon do you think you'll purchase this item again? | ||
</label> | ||
|
||
<p>Please select an option:</p> | ||
|
||
<ul> | ||
<li> | ||
<label htmlFor="soon"> Soon (7 days)</label> | ||
<input | ||
value={7} | ||
name="daysUntilNextPurchase" | ||
type="radio" | ||
id="soon" | ||
required | ||
/> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I said this to the other group as well, but the built in HTML validations actually aren't as accessible as one would hope. So I think down the road we should build our own validation + status displaying logic. |
||
</li> | ||
<li> | ||
<label htmlFor="kind-of-soon"> Kind of Soon (14 days)</label> | ||
<input | ||
value={14} | ||
name="daysUntilNextPurchase" | ||
type="radio" | ||
id="kind-of-soon" | ||
required | ||
/> | ||
</li> | ||
<li> | ||
<label htmlFor="not-soon"> Not Soon (30 days)</label> | ||
<input | ||
value={30} | ||
name="daysUntilNextPurchase" | ||
type="radio" | ||
id="not-soon" | ||
required | ||
/> | ||
</li> | ||
</ul> | ||
</div> | ||
<button type="submit">Submit</button> | ||
</form> | ||
); | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool approach here using the FormData api in conjunction with default form/input functionality to access necessary data. You don't see this often in client-side React apps, but totally legit thing to do so that's cool to see.