Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCS: adds scope to fix bug introduced in HTTPConfig support #109

Merged
merged 2 commits into from
Mar 9, 2024

Conversation

JoaoBraveCoding
Copy link
Collaborator

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Adds default scope to fix the issue reported in #106 (comment)

Verification

@JoaoBraveCoding
Copy link
Collaborator Author

JoaoBraveCoding commented Mar 4, 2024

@jhalterman This PR should fix the issue you reported (#106 (comment)), if you have the time to validate it it would be great!

@jhalterman
Copy link

This seems to resolve the previous issue. Thanks @JoaoBraveCoding.

Copy link
Member

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@saswatamcode saswatamcode enabled auto-merge (squash) March 9, 2024 07:51
@saswatamcode saswatamcode merged commit e8336a5 into thanos-io:main Mar 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants