Unit tests live markets (After isV3 flag is removed)

.dockerignore

@@ -106,4 +106,9 @@ dist
 /.idea/*
 .vscode
 .git
-/*/test/
+
+# Test folders
+/*/test/
+jest
+jest.config.js
+__mocks__

__mocks__/overtime-live-trading-utils.js

@@ -0,0 +1,105 @@
+// MOCKED functions
+
+let __gameContraints = { allow: true, message: "" };
+const __mockCheckGameContraints = (gameContraints) => (__gameContraints = gameContraints);
+const checkGameContraints = () => __gameContraints;
+
+// NOT MOCKED functions
+
+const teamNamesMatching = (leagueId, marketHomeTeam, marketAwayTeam, apiHomeTeam, apiAwayTeam, teamsMap) =>
+  jest
+    .requireActual("overtime-live-trading-utils")
+    .teamNamesMatching(leagueId, marketHomeTeam, marketAwayTeam, apiHomeTeam, apiAwayTeam, teamsMap);
+
+const gamesDatesMatching = (marketMaturityDate, apiStartDate, sportId, tennisDifferenceEnvVariable) =>
+  jest
+    .requireActual("overtime-live-trading-utils")
+    .gamesDatesMatching(marketMaturityDate, apiStartDate, sportId, tennisDifferenceEnvVariable);
+
+const getLeagueOpticOddsName = (league) =>
+  jest.requireActual("overtime-live-trading-utils").getLeagueOpticOddsName(league);
+
+const getBookmakersArray = (bookmakersData, sportId, backupLiveOddsProviders) =>
+  jest
+    .requireActual("overtime-live-trading-utils")
+    .getBookmakersArray(bookmakersData, sportId, backupLiveOddsProviders);
+
+const getLiveSupportedLeagues = (leagueInfoArray) =>
+  jest.requireActual("overtime-live-trading-utils").getLiveSupportedLeagues(leagueInfoArray);
+
+const getBetTypesForLeague = (league, leagueInfoArray) =>
+  jest.requireActual("overtime-live-trading-utils").getBetTypesForLeague(league, leagueInfoArray);
+
+const getLeagueSport = (league) => jest.requireActual("overtime-live-trading-utils").getLeagueSport(league);
+
+const getLeagueLabel = (league) => jest.requireActual("overtime-live-trading-utils").getLeagueLabel(league);
+
+const getLeagueProvider = (league) => jest.requireActual("overtime-live-trading-utils").getLeagueProvider(league);
+
+const getLeagueIsDrawAvailable = (league) =>
+  jest.requireActual("overtime-live-trading-utils").getLeagueIsDrawAvailable(league);
+
+const fetchResultInCurrentSet = (currentSet, opticOddsScoresApiResponse) =>
+  jest.requireActual("overtime-live-trading-utils").fetchResultInCurrentSet(currentSet, opticOddsScoresApiResponse);
+
+const League = jest.requireActual("overtime-live-trading-utils").League;
+const Sport = jest.requireActual("overtime-live-trading-utils").Sport;
+const MoneylineTypes = jest.requireActual("overtime-live-trading-utils").MoneylineTypes;
+const Provider = jest.requireActual("overtime-live-trading-utils").Provider;
+const PeriodType = jest.requireActual("overtime-live-trading-utils").PeriodType;
+const TotalTypes = jest.requireActual("overtime-live-trading-utils").TotalTypes;
+
+const UFC_LEAGUE_IDS = jest.requireActual("overtime-live-trading-utils").UFC_LEAGUE_IDS;
+const LeagueMap = jest.requireActual("overtime-live-trading-utils").LeagueMap;
+const LeagueIdMapEnetpulse = jest.requireActual("overtime-live-trading-utils").LeagueIdMapEnetpulse;
+const LeagueIdMapOpticOdds = jest.requireActual("overtime-live-trading-utils").LeagueIdMapOpticOdds;
+
+const processMarket = (
+  market,
+  apiResponseWithOdds,
+  liveOddsProviders,
+  spreadData,
+  isDrawAvailable,
+  defaultSpreadForLiveMarkets,
+  maxPercentageDiffBetwenOdds,
+  leagueMap,
+) =>
+  jest
+    .requireActual("overtime-live-trading-utils")
+    .processMarket(
+      market,
+      apiResponseWithOdds,
+      liveOddsProviders,
+      spreadData,
+      isDrawAvailable,
+      defaultSpreadForLiveMarkets,
+      maxPercentageDiffBetwenOdds,
+      leagueMap,
+    );
+
+module.exports = {
+  checkGameContraints,
+  __mockCheckGameContraints,
+  teamNamesMatching,
+  gamesDatesMatching,
+  getLeagueOpticOddsName,
+  getBookmakersArray,
+  getLiveSupportedLeagues,
+  getBetTypesForLeague,
+  getLeagueSport,
+  getLeagueLabel,
+  getLeagueProvider,
+  getLeagueIsDrawAvailable,
+  fetchResultInCurrentSet,
+  processMarket,
+  League,
+  Sport,
+  MoneylineTypes,
+  Provider,
+  PeriodType,
+  TotalTypes,
+  UFC_LEAGUE_IDS,
+  LeagueMap,
+  LeagueIdMapEnetpulse,
+  LeagueIdMapOpticOdds,
+};

eslint.config.mjs

@@ -4,6 +4,9 @@ import globals from "globals";
 export default [
   {
     files: ["**/*.js"],
+    env: {
+      jest: true,
+    },
     languageOptions: { sourceType: "commonjs" },
     rules: {
       "prefer-const": "error",

help.txt

@@ -50,4 +50,9 @@ docker-compose up -d overtime-v2-api-testnet
 - Access SERVER
 - Run: docker ps
 - Copy "CONTAINER ID" of redis:alpine
-- Run: docker exec -it "CONTAINER ID" redis-cli
+- Run: docker exec -it "CONTAINER ID" redis-cli
+
+### RUN TESTS ###
+npm test
+npm test -- liveMarkets.test.js
+npm test -- --testNamePattern 'checks number of live markets' --no-silent

jest.config.js

@@ -0,0 +1,7 @@
+module.exports = {
+  verbose: true,
+  setupFilesAfterEnv: ["./jest/jestInitialSetup.js"],
+  collectCoverage: true,
+  collectCoverageFrom: ["overtimeV2Api/**/*.js"],
+  coveragePathIgnorePatterns: ["contracts", "test"],
+};

jest/jestInitialSetup.js

@@ -0,0 +1,2 @@
+jest.mock("redis", () => jest.requireActual("./redisV4Mock"));
+// jest.mock("redis", () => jest.requireActual("redis-mock")); // redis V4 is not supported by redis-mock

jest/redisV4Mock.js

@@ -0,0 +1,31 @@
+// redis-mock has not been updated for node-redis v4 yet, but the main changes
+// in the API are camelCase names and promises instead of callback, so we can work around it.
+// https://github.com/yeahoffline/redis-mock/issues/195
+
+const redis = require("redis-mock");
+const { promisify } = require("util");
+
+const client = redis.createClient();
+const set = promisify(client.set).bind(client);
+const setEx = promisify(client.setex).bind(client);
+
+const v4Client = {
+  isOpen: false,
+  connect: () => (v4Client.isOpen = true),
+  get: promisify(client.get).bind(client),
+  set: (key, value) => set(key, value),
+  del: promisify(client.del).bind(client),
+  hSet: promisify(client.hset).bind(client),
+  hGet: promisify(client.hget).bind(client),
+  hDel: promisify(client.hdel).bind(client),
+  flushAll: promisify(client.flushall).bind(client),
+  setEx: promisify(client.setex).bind(client),
+  expire: promisify(client.expire).bind(client),
+  mGet: promisify(client.mget).bind(client),
+  mSet: promisify(client.mset).bind(client),
+  pSetEx: (key, ms, value) => setEx(key, ms / 1000, value),
+  on: () => v4Client,
+  // Add additional functions as needed...
+};
+
+module.exports = { ...redis, createClient: () => v4Client };

overtimeV2Api/constants/markets.js

@@ -1637,7 +1637,6 @@ const PARENT_MARKET_PROPERTIES_TO_EXCLUDE = [
   "isPlayerPropsMarket",
   "isOneSidePlayerPropsMarket",
   "isYesNoPlayerPropsMarket",
-  "isV3",
 ];
 
 const CHILD_MARKET_PROPERTIES_TO_EXCLUDE = [

overtimeV2Api/source/liveMarkets.js

@@ -63,7 +63,8 @@ async function processLiveMarkets() {
           const startTime = new Date().getTime();
           logAllInfo(`Live markets ${network}: process live markets`);
 
-          await processAllMarkets(
+          // call function from the same file with module.exports for unit tests mocking purpose
+          await module.exports.processAllMarkets(
             oddsStreamsInfoByLeagueMap,
             oddsInitializedByLeagueMap,
             resultsInitializedByLeagueMap,
@@ -110,9 +111,7 @@ async function processAllMarkets(
   const openMarketsMap = new Map(JSON.parse(openMarkets));
 
   const supportedLiveMarkets = Array.from(openMarketsMap.values())
-    .filter(
-      (market) => !!market.isV3 && market.statusCode === "ongoing" && !market.isWholeGameResolved && !market.noTickets,
-    )
+    .filter((market) => market.statusCode === "ongoing" && !market.isWholeGameResolved && !market.noTickets)
     .filter((market) => supportedLiveLeagueIds.includes(market.leagueId));
   const uniqueLiveLeagueIds = uniq(supportedLiveMarkets.map((market) => market.leagueId));
 
@@ -450,7 +449,6 @@ async function processMarketsByLeague(
         market.proof = [];
         market.homeScoreByPeriod = gamesHomeScoreByPeriod;
         market.awayScoreByPeriod = gamesAwayScoreByPeriod;
-        market.isV3 = true;
 
         if (!errorMessage) {
           const processedMarket = processMarket(
@@ -503,4 +501,5 @@ async function processMarketsByLeague(
 
 module.exports = {
   processLiveMarkets,
+  processAllMarkets,
 };

overtimeV2Api/source/liveScores.js

@@ -77,7 +77,7 @@ async function processAllLiveResults(resultsInitialization, isTestnet) {
     const leagueProvider = getLeagueProvider(leagueId);
     const gameInfo = gamesInfoMap.get(market.gameId);
 
-    if (leagueProvider === Provider.OPTICODDS && market.isV3) {
+    if (leagueProvider === Provider.OPTICODDS) {
       opticOddsGameIdsWithLeagueID.push({ gameId: market.gameId, leagueId, gameInfo });
     }
   }

overtimeV2Api/source/markets.js

@@ -147,10 +147,10 @@ const loadMarkets = async (isTestnet, shouldDoFullUpdate) => {
 };
 
 const mapMarket = (market) => {
-  const packedMarket = packMarket(market, false);
+  const packedMarket = packMarket(market);
   packedMarket.childMarkets = [];
   market.childMarkets.forEach((childMarket) => {
-    const packedChildMarket = packMarket(childMarket, true);
+    const packedChildMarket = packMarket(childMarket);
     packedMarket.childMarkets.push(packedChildMarket);
   });
 

overtimeV2Api/test/index.test.js

@@ -0,0 +1,7 @@
+describe("Check OvertimeV2 initialization", () => {
+  it("checks redis client is connected", async () => {
+    require("../index");
+    const { redisClient } = require("../../redis/client");
+    expect(redisClient.isOpen).toBe(true);
+  });
+});

overtimeV2Api/test/indexTestnet.test.js

@@ -0,0 +1,7 @@
+describe("Check OvertimeV2 testnet initialization", () => {
+  it("checks redis client is connected", async () => {
+    require("../indexTestnet");
+    const { redisClient } = require("../../redis/client");
+    expect(redisClient.isOpen).toBe(true);
+  });
+});