Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the #177 #182

Closed
wants to merge 6 commits into from
Closed

fix the #177 #182

wants to merge 6 commits into from

Conversation

ponytailer
Copy link

@ponytailer ponytailer commented Dec 4, 2017

fix the #177 : when the function has the magic arguments, the make_memorize_cache_key has the bug.

@ponytailer
Copy link
Author

ponytailer commented Dec 4, 2017

The CI has been down.

@dengshaochun
Copy link

#174
error msg

$ python --version
Python 2.7.13
$ pip --version
pip 9.0.1 from /home/travis/virtualenv/python2.7.13/lib/python2.7/site-packages (python 2.7)
0.28s$ pip install . --use-mirrors
Usage:   
  pip install [options] <requirement specifier> [package-index-options] ...
  pip install [options] -r <requirements file> [package-index-options] ...
  pip install [options] [-e] <vcs project url> ...
  pip install [options] [-e] <local project path> ...
  pip install [options] <archive url/path> ...
no such option: --use-mirrors
The command "pip install . --use-mirrors" failed and exited with 2 during .

@ponytailer
Copy link
Author

Got it, thanks

@ponytailer
Copy link
Author

But, maybe the author has not accepted the new PR.

@ponytailer
Copy link
Author

ponytailer commented Dec 4, 2017

Now, memorize support the magic arguments, so remove and fixed those test case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants