-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support RN 0.76 + add example with RNTA #538
Conversation
This looks great, gonna take some time to properly review and test in a few days. |
Android build failure will be resolved by using https://github.com/software-mansion/react-native-screens/releases/tag/4.0.0-beta.13 |
I also have some report of the build still failing on android (#542), if you have the chance could you also check if the new example app works on android? |
fcee673
to
0a1450c
Compare
92add25
to
2169743
Compare
@janicduplessis I installed the .76 - compatible deps and CI is passing. However, I removed the macos example which was just recently added. |
Since rn macos always seem to he a bit behind rn versions I think we will have to have a different example app sadly. |
Summary
same as #537 but also includes an example app that uses react-native-test-app. You can take it, or ignore it - up to you.
used
npx --package react-native-test-app@latest init
to create the example. Then copied over the src folder from the old example.Test Plan
There's a patch for react-native-screens taken from https://github.com/software-mansion/react-native-screens/pull/2407/files#diff-59c313fb0dfe322996885368a5a90d8f8400c2576bb64acc60467c2e79ecd2e9
then build as ususal