feat: poll | Add upload form #860
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
It's great having you contribute to this project
🌟 Welcome to the community 🌟
- If you would like to continue contributing to open source and would like to do it with an awesome inclusive community.
- You should join our Discord chat and our GitHub Organisation.
- We help and encourage each other to contribute to open source little and often 😄.
- Any questions let us know.
|
@ArkadiK94 Can you add code review ? |
ArkadiK94
suggested changes
Jun 14, 2024
src/components/Feeds/FeedPoll/uploadPollForm/UploadPollForm.jsx
Outdated
Show resolved
Hide resolved
src/components/Feeds/FeedPoll/uploadPollForm/UploadPollForm.jsx
Outdated
Show resolved
Hide resolved
| }; | ||
|
|
||
| const addAnswer = () => { | ||
| setAnswers((prevAnswers) => [...prevAnswers, prevAnswers.length + 1]); |
There was a problem hiding this comment.
I think you should store the number of answers as number and not array
you don't get anything from storing it as [1,2,3]... why not 3 instead?
| <Form onSubmit={handleSubmit(onSubmit)}> | ||
| <Title>Add a question</Title> | ||
| <QuestionBody | ||
| errorMessage={errors?.question?.message} |
There was a problem hiding this comment.
Yes, try to submit short question
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #841
This is the form (right now not connected to any backend) :
pollUplode.mp4
Right now, the Zod validation validates things in a kind of "hardcoded way," but since the maximum number of answers won't change often, I think it's okay. I can think of other solutions if we want to implement dynamic answer numbers.
Also, it`s not in the video but there is a check for the minimum question length :