Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OD with Nix #2032

Merged
merged 11 commits into from
Nov 30, 2024
Merged

Fix OD with Nix #2032

merged 11 commits into from
Nov 30, 2024

Conversation

Cyberboss
Copy link
Member

Wasn't working, now it does

🆑
For better compatibility with nix, OpenDream executables are no longer invoked directly. Instead the dotnet executable will be used on the .dll's.
/:cl:

@Cyberboss Cyberboss added the Fix Fixes incorrect functionality label Nov 27, 2024
@Cyberboss Cyberboss added this to the v6.12.0 milestone Nov 27, 2024
tgstation-server-ci[bot]
tgstation-server-ci bot previously approved these changes Nov 27, 2024
tgstation-server-ci[bot]
tgstation-server-ci bot previously approved these changes Nov 28, 2024
tgstation-server-ci[bot]
tgstation-server-ci bot previously approved these changes Nov 28, 2024
Copy link

codecov bot commented Nov 30, 2024

Codecov Report

Attention: Patch coverage is 83.65385% with 17 lines in your changes missing coverage. Please review.

Project coverage is 95.62%. Comparing base (cd32053) to head (9bb0419).
Report is 14 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2032      +/-   ##
==========================================
- Coverage   95.63%   95.62%   -0.01%     
==========================================
  Files         811      811              
  Lines      175232   175244      +12     
  Branches     3549     3553       +4     
==========================================
- Hits       167584   167582       -2     
- Misses       7077     7091      +14     
  Partials      571      571              

@Cyberboss Cyberboss merged commit 179572f into dev Nov 30, 2024
80 checks passed
@Cyberboss Cyberboss deleted the FixDotnetOD branch November 30, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fixes incorrect functionality size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant