Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not attempt to checkout a detached SHA on reclone #1991

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Conversation

Cyberboss
Copy link
Member

@Cyberboss Cyberboss commented Oct 27, 2024

🆑
Re-cloning a repository no longer attempts to checkout the exact SHA that it was previously on, rather using the reference instead. This was problematic with SHAs that were generated by test merges. If no reference is available, the default branch on the origin will be cloned.
/:cl:

@Cyberboss Cyberboss added this to the v6.12.0 milestone Oct 27, 2024
@Cyberboss Cyberboss enabled auto-merge October 27, 2024 15:59
tgstation-server-ci[bot]
tgstation-server-ci bot previously approved these changes Oct 27, 2024
@Cyberboss Cyberboss added Fix Fixes incorrect functionality Area: Repository With regard to managing the git repository labels Nov 10, 2024
Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.63%. Comparing base (2aa16e8) to head (08f0caf).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1991      +/-   ##
==========================================
- Coverage   95.63%   95.63%   -0.01%     
==========================================
  Files         811      811              
  Lines      175245   175233      -12     
  Branches     3549     3549              
==========================================
- Hits       167603   167583      -20     
- Misses       7072     7080       +8     
  Partials      570      570              

@Cyberboss Cyberboss merged commit c500ec4 into dev Nov 10, 2024
84 checks passed
@Cyberboss Cyberboss deleted the RepoRecloneFix branch November 10, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Repository With regard to managing the git repository Fix Fixes incorrect functionality size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant