Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu 24 becoming latest fixes #1973

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Ubuntu 24 becoming latest fixes #1973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ad5884
Fix jobs missing libgdiplus
Cyberboss Oct 13, 2024
4f30501
Upload .deb logs on failure `systemctl status` failure
Cyberboss Oct 14, 2024
86ed9ab
Put the systemd service test database file in an owned directory
Cyberboss Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 36 additions & 2 deletions .github/workflows/ci-pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,11 @@ jobs:
name: Build ReleaseNotes for Other Jobs
runs-on: ubuntu-latest
steps:
- name: Install Native Dependencies
run: |
sudo apt-get update
sudo apt-get install -y libgdiplus

- name: Setup dotnet
uses: actions/setup-dotnet@v4
with:
Expand Down Expand Up @@ -84,6 +89,11 @@ jobs:
env:
TGS_TELEMETRY_KEY_FILE: /tmp/tgs_telemetry_key.txt
steps:
- name: Install Native Dependencies
run: |
sudo apt-get update
sudo apt-get install -y libgdiplus

- name: Setup dotnet
uses: actions/setup-dotnet@v4
with:
Expand Down Expand Up @@ -1359,7 +1369,7 @@ jobs:
- name: Test Install
run: |
sudo mkdir /etc/tgstation-server
sudo cp build/package/appsettings.GitHub.yml /etc/tgstation-server/appsettings.Production.yml
sudo cp build/package/deb/appsettings.GitHub.yml /etc/tgstation-server/appsettings.Production.yml
sudo apt-get install -y ./tgstation-server_${{ env.TGS_VERSION }}-1_amd64.deb
sudo ls -al /etc/tgstation-server
sudo cat /etc/tgstation-server/appsettings.Production.yml
Expand All @@ -1369,8 +1379,32 @@ jobs:
cat /usr/bin/tgs-configure

- name: Test Service
id: test-service
run: |
set +e
systemctl status tgstation-server
retval=$?
set -e
if [[ $retval -ne 0 ]]; then
echo "succeeded=NO" >> $GITHUB_OUTPUT
else
echo "succeeded=YES" >> $GITHUB_OUTPUT
fi

- name: Chown Errored Service Logs
if: ${{ steps.test-service.outputs.succeeded == 'NO' }}
run: sudo chown -R runner /var/log/tgstation-server

- name: Store Errored Service Logs
if: ${{ steps.test-service.outputs.succeeded == 'NO' }}
uses: actions/upload-artifact@v4
with:
name: systemd-service-logs
path: /var/log/tgstation-server/**/*

- name: Fail if Service Errored
if: ${{ steps.test-service.outputs.succeeded == 'NO' }}
run: exit 1

- name: Test Uninstall # Wait 10s for service to initialize
shell: bash
Expand Down Expand Up @@ -1480,7 +1514,7 @@ jobs:
shell: powershell # If it's missing, I found that <PrivateAssets> in <PackageReference> elements were the problem
run: |
mkdir C:/ProgramData/tgstation-server
cp build/package/appsettings.GitHub.yml C:/ProgramData/tgstation-server/appsettings.Production.yml
cp build/package/winget/appsettings.GitHub.yml C:/ProgramData/tgstation-server/appsettings.Production.yml
$file = [System.IO.Path]::GetFullPath("build/package/winget/test-installer.exe")
$log = [System.IO.Path]::GetFullPath("install.log")
$procMain = Start-Process -FilePath $file "/install /silent /log `"$log`"" -NoNewWindow -PassThru -Wait
Expand Down
26 changes: 26 additions & 0 deletions build/package/deb/appsettings.GitHub.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
# Barebones config file used for testing service installs in GitHub actions
Database:
DatabaseType: Sqlite
ConnectionString: Data Source=/home/tgstation-server/tgs.sqlite3;Mode=ReadWriteCreate
General:
ConfigVersion: 4.6.0
ApiPort: 5000
GitHubAccessToken:
SetupWizardMode: Never
ByondTopicTimeout: 5000
RestartTimeoutMinutes: 1
ShutdownTimeoutMinutes: 300
UseBasicWatchdog: false
HostApiDocumentation: true
SkipAddingByondFirewallException: false
DeploymentDirectoryCopyTasksPerCore:
MinimumPasswordLength: 15
InstanceLimit: 10
UserLimit: 100
UserGroupLimit: 25
ValidInstancePaths:
FileLogging:
Directory:
Disable: false
LogLevel: Trace
MicrosoftLogLevel: Warning
0 build/package/appsettings.GitHub.yml → build/package/winget/appsettings.GitHub.yml
View file
Open in desktop
File renamed without changes.
2 changes: 2 additions & 0 deletions tgstation-server.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "package", "package", "{2648
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "deb", "deb", "{457A1F89-6201-4430-BCC6-2F4438A54B9E}"
ProjectSection(SolutionItems) = preProject
build\package\deb\appsettings.GitHub.yml = build\package\deb\appsettings.GitHub.yml
build\package\deb\build_package.sh = build\package\deb\build_package.sh
build\package\deb\install_artifacts.sh = build\package\deb\install_artifacts.sh
build\package\deb\MakeInstall = build\package\deb\MakeInstall
Expand All @@ -244,6 +245,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "upstream", "upstream", "{B4
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "winget", "winget", "{506B9092-AF88-4DA2-84FD-C11646B695B0}"
ProjectSection(SolutionItems) = preProject
build\package\winget\appsettings.GitHub.yml = build\package\winget\appsettings.GitHub.yml
build\package\winget\install_banner.jpg = build\package\winget\install_banner.jpg
build\package\winget\prepare_installer_input_artifacts.ps1 = build\package\winget\prepare_installer_input_artifacts.ps1
build\package\winget\push_manifest.ps1 = build\package\winget\push_manifest.ps1
Expand Down
Loading