Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow DMAPI Validation to be fully skipped #1923

Merged
merged 5 commits into from
Sep 8, 2024
Merged

Conversation

Cyberboss
Copy link
Member

Fuck you @AffectedArc07

🆑
Allowed DMAPI validation to be skipped. Note that skipping DMAPI validation disables all DMAPI functionality for a deployment, even if it is present in your DM code.

🆑 HTTP API
Added dmApiValidationMode to /api/DreamMaker request and response model. This enum can either be 0 for validation optional, 1 for validation required, or 2 for validation skipped.
Deprecation: requireDMApiValidation in the /api/DreamMaker request and response models is now deprecated, use dmApiValidationMode instead.
/🆑

🆑 Nuget: API
Added Tgstation.Server.Api.Models.DMApiValidationMode.
Added DreamMakerSettings.DMApiValidationMode.
Deprecation: Make DreamMakerSettings.RequireDMApiValidation obsolete. Use DreamMakerSettings.DMApiValidationMode instead.
/🆑

🆑 Nuget: Client
Updated Tgstation.Server.Api dependency to 14.1.0 for TGS API version 10.9.0.
/🆑

@Cyberboss Cyberboss added Client Issue with the .NET client library Feature New functionality REST The JSON REST API for server control Area: Compiler With regard to managing the deployment process labels Sep 7, 2024
@Cyberboss Cyberboss added this to the v6.10.0 milestone Sep 7, 2024
@Cyberboss Cyberboss enabled auto-merge September 7, 2024 19:08
@Cyberboss Cyberboss disabled auto-merge September 7, 2024 19:08
tgstation-server-ci[bot]
tgstation-server-ci bot previously approved these changes Sep 7, 2024
@Cyberboss Cyberboss enabled auto-merge September 7, 2024 19:08
tgstation-server-ci[bot]
tgstation-server-ci bot previously approved these changes Sep 7, 2024
tgstation-server-ci[bot]
tgstation-server-ci bot previously approved these changes Sep 8, 2024
tgstation-server-ci[bot]
tgstation-server-ci bot previously approved these changes Sep 8, 2024
tgstation-server-ci[bot]
tgstation-server-ci bot previously approved these changes Sep 8, 2024
tgstation-server-ci[bot]
tgstation-server-ci bot previously approved these changes Sep 8, 2024
tgstation-server-ci[bot]
tgstation-server-ci bot previously approved these changes Sep 8, 2024
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

Attention: Patch coverage is 99.72267% with 12 lines in your changes missing coverage. Please review.

Project coverage is 95.92%. Comparing base (2df11b4) to head (6c0f9fa).
Report is 6 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1923      +/-   ##
==========================================
+ Coverage   95.81%   95.92%   +0.11%     
==========================================
  Files         717      725       +8     
  Lines      164124   168407    +4283     
  Branches     3291     3296       +5     
==========================================
+ Hits       157255   161546    +4291     
+ Misses       6363     6358       -5     
+ Partials      506      503       -3     

@Cyberboss Cyberboss merged commit 0795258 into dev Sep 8, 2024
77 checks passed
@Cyberboss Cyberboss deleted the SkipDMAPIValidation branch September 8, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Compiler With regard to managing the deployment process Client Issue with the .NET client library Feature New functionality REST The JSON REST API for server control size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant