-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow DMAPI Validation to be fully skipped #1923
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cyberboss
added
Client
Issue with the .NET client library
Feature
New functionality
REST
The JSON REST API for server control
Area: Compiler
With regard to managing the deployment process
labels
Sep 7, 2024
Cyberboss
force-pushed
the
SkipDMAPIValidation
branch
from
September 7, 2024 22:41
c148af5
to
4570a20
Compare
…nux advanced watchdog failures
Cyberboss
force-pushed
the
SkipDMAPIValidation
branch
from
September 8, 2024 05:25
e7b8c1d
to
5696aa5
Compare
Cyberboss
force-pushed
the
SkipDMAPIValidation
branch
from
September 8, 2024 16:03
d4823a2
to
8669159
Compare
Cyberboss
force-pushed
the
SkipDMAPIValidation
branch
from
September 8, 2024 17:33
8669159
to
74f680e
Compare
Cyberboss
force-pushed
the
SkipDMAPIValidation
branch
from
September 8, 2024 19:19
74f680e
to
f2e9fb2
Compare
…the watchdog is doing here with this change
Cyberboss
force-pushed
the
SkipDMAPIValidation
branch
from
September 8, 2024 19:19
f2e9fb2
to
6c0f9fa
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1923 +/- ##
==========================================
+ Coverage 95.81% 95.92% +0.11%
==========================================
Files 717 725 +8
Lines 164124 168407 +4283
Branches 3291 3296 +5
==========================================
+ Hits 157255 161546 +4291
+ Misses 6363 6358 -5
+ Partials 506 503 -3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: Compiler
With regard to managing the deployment process
Client
Issue with the .NET client library
Feature
New functionality
REST
The JSON REST API for server control
size/XXL
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fuck you @AffectedArc07
🆑
Allowed DMAPI validation to be skipped. Note that skipping DMAPI validation disables all DMAPI functionality for a deployment, even if it is present in your DM code.
🆑 HTTP API
Added
dmApiValidationMode
to/api/DreamMaker
request and response model. This enum can either be0
for validation optional,1
for validation required, or2
for validation skipped.Deprecation:
requireDMApiValidation
in the/api/DreamMaker
request and response models is now deprecated, usedmApiValidationMode
instead./🆑
🆑 Nuget: API
Added
Tgstation.Server.Api.Models.DMApiValidationMode
.Added
DreamMakerSettings.DMApiValidationMode
.Deprecation: Make
DreamMakerSettings.RequireDMApiValidation
obsolete. UseDreamMakerSettings.DMApiValidationMode
instead./🆑
🆑 Nuget: Client
Updated
Tgstation.Server.Api
dependency to 14.1.0 for TGS API version 10.9.0./🆑