-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warns when running TGS as root #1882
Conversation
Also, ngl, these webedits really make me want to go against my principle of only using merge commits. |
move checking root to CheckSystemCompatibility use Syscall internal getuid
not a single commit was a web edit; it was me struggling to get dotnet to actually build locally until I realized that I had to manually specify NoWindows as a configuration because it is not automatically detected |
Co-authored-by: Jordan Dominion <[email protected]>
Co-authored-by: Jordan Dominion <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1882 +/- ##
==========================================
- Coverage 95.84% 95.81% -0.03%
==========================================
Files 716 716
Lines 163744 163921 +177
Branches 3265 3263 -2
==========================================
+ Hits 156939 157063 +124
- Misses 6300 6353 +53
Partials 505 505 |
🆑
Running as root on Linux now issues a warning outside of Docker.
/🆑
Running any service under the root user when it is not a system service is not recommended. We already install under a dedicated user for the apt packages so we should warn, and in the future error out, when running as root.