Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release ValueTask converted client package #1679

Merged
merged 3 commits into from
Oct 21, 2023
Merged

Release ValueTask converted client package #1679

merged 3 commits into from
Oct 21, 2023

Conversation

Cyberboss
Copy link
Member

@Cyberboss Cyberboss commented Oct 20, 2023

Also fix build errors caused by the last master merge

🆑 Nuget: Client
Replaced most usages of Task with ValueTask.
/:cl:

🆑 Nuget: Common
Added ValueTask WhenAll helpers.
Changed return type of CachedResponseStream.Create from Task<T> to ValueTask<T>
/:cl:

@Cyberboss Cyberboss added the Client Issue with the .NET client library label Oct 20, 2023
@Cyberboss Cyberboss added this to the v5.17.0 milestone Oct 20, 2023
@Cyberboss Cyberboss enabled auto-merge October 20, 2023 23:57
github-actions[bot]
github-actions bot previously approved these changes Oct 20, 2023
@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Merging #1679 (6d674a7) into dev (9011cf3) will decrease coverage by 0.07%.
Report is 8 commits behind head on dev.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1679      +/-   ##
==========================================
- Coverage   95.00%   94.94%   -0.07%     
==========================================
  Files         607      607              
  Lines      126593   126593              
  Branches        0     2799    +2799     
==========================================
- Hits       120271   120195      -76     
+ Misses       6322     5921     -401     
- Partials        0      477     +477     

@Cyberboss Cyberboss merged commit 8a27fdc into dev Oct 21, 2023
97 checks passed
@Cyberboss Cyberboss deleted the NugetRelease branch October 21, 2023 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client Issue with the .NET client library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant