v5.16.3: Fix PosixWatchdog #1677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cyberboss
added
Fix
- IDmbProvider is now `AsyncDisposable` as opposed to `IDisposable`. - Add hard link support to `ISymlinkFactory`. - `PosixWatchdog` now has to mirror deployment structure as hard links before swapping. Because of this deployments may not immediately be applied if the reboots immediately after they were completed.
Move Windows specific functionality out to `WindowsWatchdog`.
Cyberboss
force-pushed
the
FixLinuxFuckingBullshit
branch
from
36d2115 to
5bb655e
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Cyberboss
force-pushed
the
FixLinuxFuckingBullshit
branch
from
af8b89b to
b223680
Compare
Cyberboss
added
Area: Compiler
Cyberboss
changed the title
|
Merging with |
Cyberboss
force-pushed
the
FixLinuxFuckingBullshit
branch
from
6c3e7ff to
c360592
Compare
Cyberboss
force-pushed
the
FixLinuxFuckingBullshit
branch
from
c360592 to
cfca47d
Compare
Cyberboss
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1677 +/- ##
========================================
Coverage 94.92% 94.92%
========================================
Files 606 609 +3
Lines 126542 126725 +183
Branches 2788 2803 +15
========================================
+ Hits 120119 120299 +180
- Misses 5942 5945 +3
Partials 481 481 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🆑
Fixed issues with DreamDaemon referencing the original true path of instances when using the advanced watchdog on Linux. Hard linked copies of deployment directory structure are now used instead of symlinks.
If a deployment completes on Linux right before a world with a valid DMAPI reboots it may not have enough time to be applied and delayed until the next reboot.
/:cl:
Fixes #1680
ISymlinkFactorytoIFileSystemLinkFactorySwappableDmbProvidertoSymlinkDmbProvider.WindowsWatchdogcode into abstractAdvancedWatchdog.