MSBuild project dependency black magic

tgstation · Sep 9, 2024 · 371a758 · 371a758
1 parent 80c7def
commit 371a758
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/src/Tgstation.Server.Client.GraphQL/Tgstation.Server.Client.GraphQL.csproj b/src/Tgstation.Server.Client.GraphQL/Tgstation.Server.Client.GraphQL.csproj
@@ -13,20 +13,23 @@
 
   <ItemGroup>
     <ProjectReference Include="..\Tgstation.Server.Client\Tgstation.Server.Client.csproj" />
-    <ProjectReference Include="..\Tgstation.Server.Host\Tgstation.Server.Host.csproj">
-      <ReferenceOutputAssembly>false</ReferenceOutputAssembly>
-    </ProjectReference>
   </ItemGroup>
 
+  <!-- https://github.com/dotnet/msbuild/issues/2661#issuecomment-338808147 -->
+  <Target Name="WorkaroundSdk939" BeforeTargets="ImportGraphQLApiSchema">
+    <MSBuild Projects="..\Tgstation.Server.Host\Tgstation.Server.Host.csproj" />
+  </Target>
+
   <Target Name="DeleteGeneratedFiles" BeforeTargets="ImportGraphQLApiSchema">
     <RemoveDir Directories="$(IntermediateOutputPath)berry" />
   </Target>
 
-  <Target Name="ImportGraphQLApiSchema" BeforeTargets="BeforeBuild" Inputs="../../artifacts/tgs-api.graphql" Outputs="schema.graphql">
+  <!-- https://github.com/ChilliCream/graphql-platform/blob/c0c8df525ca0f47bf3b3b409a8b22cbe37f7a9c0/src/StrawberryShake/MetaPackages/Common/MSBuild/StrawberryShake.targets#L20 -->
+  <Target Name="ImportGraphQLApiSchema" BeforeTargets="_GraphQLCodeGenerationRoot" Inputs="../../artifacts/tgs-api.graphql" Outputs="schema.graphql">
     <Copy SkipUnchangedFiles="true" SourceFiles="../../artifacts/tgs-api.graphql" DestinationFiles="schema.graphql" />
   </Target>
 
-  <Target Name="FixWarningsInGeneratedSchema" BeforeTargets="CoreCompile">
+  <Target Name="FixWarningsInGeneratedSchema" AfterTargets="GenerateGraphQLCode">
     <PropertyGroup>
       <InputFile>$(IntermediateOutputPath)berry/GraphQLClient.Client.cs</InputFile>
       <OutputFile>$(IntermediateOutputPath)berry/GraphQLClient.Client.cs</OutputFile>