-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor iconforge fixes #197
base: master
Are you sure you want to change the base?
Conversation
@itsmeow please advise |
Just need to run a tracy profile on this and compare the performance and it's good with me |
Added another fix for another bug I found: |
So turns out this is way horrible for performance and is likely related to having massive spritesheet file sizes and no page cache on the Linux runners? I'm not sure if merging this is a good idea as they work fine for spritesheets that aren't massive and this adds seconds of overhead to small spritesheets that don't have issues. This needs to check for a certain size (what that size is, I have no idea) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checking in, is all this code still needed?
For some use cases yes. It adds a little bit of overhead, but it's acceptable. The bug fix is necessary. |
Just fixes a width() call where there should be height()