Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IconForge: GAGS #188

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

itsmeow
Copy link
Contributor

@itsmeow itsmeow commented Sep 16, 2024

Re-implements GAGS config loading and icon generation using IconForge, can basically 1:1 replace any GAGS generate() tasks in DM and can be up to 250x faster per unique config-color combination. Worst case goes from 250ms to 1ms.

Works by outputting the result to a DMI in tmp and assigning it to icon in DM.

This version of GAGS does not support (it will soft fail and just not generate the icon correctly):

  • The color_matrix layer type
  • The or blending mode
  • BYOND Parity on obscure operations with multiple icon_states at the same time (animated sprites, unscoped/stateless icons, mixed-dirs aka overlaying icons with different dir amounts)

image

A DM implementation can be found in this PR: BeeStation/BeeStation-Hornet#10455

This has been in active use on prod since January 2024 with zero issues.

This works to address tgstation/dev-cycles-initiative#9 if it were to be implemented on TG

@ZeWaka ZeWaka requested a review from Mothblocks September 16, 2024 15:30
@optimumtact
Copy link
Member

what is blocking this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants