Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardizes Dropship Hazard Stripe Outlines #14019

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

AzonStarfall
Copy link
Contributor

About The Pull Request

Standardizes all Dropship, CAS, and Tadpole shipside pads to use the same hazard stripe object outline.

2023-09-24 22 23 38
2023-09-24 22 23 41
2023-09-24 22 23 45

Why It's Good For The Game

Currently, the ships that use hazard stripes for dropship outlines use the turf version, not the object version. While this initially has no visual impact, once a dropship leaves the occupied tile, these tiles reset to the default downward-facing orientation, which looks bad. This PR changes this so that the hazard stripes never occupy an area underneath the dropship spawn zone, preventing this issue.

Screenshot 2023-09-24 224018

For the case of the Tadpole, since there are variable configurations, the hazard stripes being swapped for the object version instead of the turf version means that even in the case of overlapping with the longer Tadpoles, it will simply delete the stripes instead of causing the direction reset you'd see with the turf variant.

Changelog

🆑
qol: Standardized hazard stripes for dropship outlines across all ships.
/:cl:

@tgstation-server tgstation-server added Map Edit One or more changes to .dmm files. Quality of Life Minor changes that make the game nicer to play labels Sep 25, 2023
@RipGrayson RipGrayson merged commit c3fa469 into tgstation:master Sep 25, 2023
6 of 7 checks passed
github-actions bot added a commit that referenced this pull request Sep 25, 2023
@AzonStarfall AzonStarfall deleted the landingstripesfix branch September 26, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map Edit One or more changes to .dmm files. Quality of Life Minor changes that make the game nicer to play
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants