Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds An Eyewear Category to Clothing Vendor #13999

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

Wisemonster
Copy link
Contributor

@Wisemonster Wisemonster commented Sep 22, 2023

About The Pull Request

Adds an eyewear category to the clothing vendor, with various cosmetic and prescription sunglasses from the loadout prefs. Also moves the ballistic goggles from headwear to this new category.
Change Me - Pillar of Spring 9_21_2023 9_48_22 PM

(Note: The duplicate sunglasses are due to the shades and sunglasses sharing the same name. Each of the sunglasses are the fake kind, so they do not provide flash protection.)

Why It's Good For The Game

Having the cosmetic eyewear all in the same place will make customizing your character less tedious and difficult. Also the ballistic goggles being in headwear didn't really make much sense.

Changelog

🆑
add: Added an eyewear category to the surplus clothing vendor, containing various cosmetic and prescription eyewear.
del: Moved the ballistic goggles from the headwear category to the new eyewear category.
/:cl:

@tgstation-server tgstation-server added Removal Feature removal due to maintainibility or design direction. Feature New interesting mechanics with new interesting bugs labels Sep 22, 2023
@Pariah919
Copy link
Contributor

At this point, we need subtabs.

@Blundir
Copy link
Contributor

Blundir commented Sep 23, 2023

Adding gear customization exclusives to vendors... why?

@Wisemonster
Copy link
Contributor Author

Adding gear customization exclusives to vendors... why?

I'm not sure what you mean? All of the headwear in the loadout pref is available from the vendor already from the surplus headwear tab, and the ballistic goggles were also already available from the headwear tab (for some reason). I'm also not removing them from the loadout pref, simply also adding them to the surplus clothing vendor. I'm also not sure why the items that are exclusive NEED to be exclusive to the loadout pref, considering this just makes trying them out to see how they look require respawns, due to loadout prefs not spawning in Valhalla.

@Blundir
Copy link
Contributor

Blundir commented Sep 23, 2023

Adding gear customization exclusives to vendors... why?

I'm not sure what you mean? All of the headwear in the loadout pref is available from the vendor already from the surplus headwear tab, and the ballistic goggles were also already available from the headwear tab (for some reason). I'm also not removing them from the loadout pref, simply also adding them to the surplus clothing vendor. I'm also not sure why the items that are exclusive NEED to be exclusive to the loadout pref, considering this just makes trying them out to see how they look require respawns, due to loadout prefs not spawning in Valhalla.

Sunglasses were always preference gear exclusive, they aren't in the vendor currently, your own pr shows it, and if you so want to give people ability to test them out in Valhalla, there is a whole another vendor with its own list for Valhalla stuff

@Wisemonster
Copy link
Contributor Author

Wisemonster commented Sep 23, 2023

My question still stands: Why do they NEED to be loadout pref exclusive? The sunglasses do not provide any flash protection, so I'm not sure why any of these items need to be exclusive.

@Blundir
Copy link
Contributor

Blundir commented Sep 24, 2023

My question still stands: Why do they NEED to be loadout pref exclusive? The sunglasses do not provide any flash protection, so I'm not sure why any of these items need to be exclusive.

Why don't? It always kept that small bit of backstory and character, you just make the system of gear preference even less used, the people who wanted sunglasses always got them, you just make the process trivial.

@Wisemonster
Copy link
Contributor Author

So should we remove all items that are in the loadout prefs from vendors then? Cause currently there's plenty of surplus headwear that's in the loadout pref that's also in the surplus clothing vendor, and ballistic goggles are already in the vendor, albeit in the headwear category. The loadout prefs means you don't have to visit the surplus clothing vendor each time you spawn if you find some headwear/glasses you like, although finding out which glasses you like is somewhat difficult at the moment due to some of the glasses being loadout pref only.

@Blundir
Copy link
Contributor

Blundir commented Sep 25, 2023

So should we remove all items that are in the loadout prefs from vendors then? Cause currently there's plenty of surplus headwear that's in the loadout pref that's also in the surplus clothing vendor, and ballistic goggles are already in the vendor, albeit in the headwear category. The loadout prefs means you don't have to visit the surplus clothing vendor each time you spawn if you find some headwear/glasses you like, although finding out which glasses you like is somewhat difficult at the moment due to some of the glasses being loadout pref only.

As i already said, add them to Valhalla vendor instead, exclusivity preserved, and ability to try them out is added.

Copy link
Contributor

@ivanmixo ivanmixo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blundir being silly, this is a good PR.

@ivanmixo ivanmixo merged commit 0ee734f into tgstation:master Sep 26, 2023
7 checks passed
github-actions bot added a commit that referenced this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New interesting mechanics with new interesting bugs Removal Feature removal due to maintainibility or design direction.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants