Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gun Smoke Particles #13963

Merged
merged 5 commits into from
Sep 26, 2023
Merged

Gun Smoke Particles #13963

merged 5 commits into from
Sep 26, 2023

Conversation

tyeagg
Copy link
Contributor

@tyeagg tyeagg commented Sep 16, 2023 •
edited by github-actions bot
Loading

About The Pull Request

when you fire gun smoke come out

smo.mp4

Why It's Good For The Game

looks cool

Changelog

🆑
add: smoke particles for gun firing
/:cl:

@tgstation-server tgstation-server added the Feature New interesting mechanics with new interesting bugs label Sep 16, 2023
@novaepee
Copy link
Contributor

TGMC: The Woo Edition

tumblr_n2v3gbDdnT1sgrxw6o1_500-4208352554

@yyzsong
Copy link
Contributor

yyzsong commented Sep 16, 2023

Please do not make firefights even more of a headache than they usually are.

Kuro020
Kuro020 approved these changes Sep 16, 2023
View reviewed changes
Copy link
Member

@Kuro020 Kuro020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Speedmerge or @TiviPlus is cringe

Lumipharon
Lumipharon requested changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@Lumipharon Lumipharon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do energy weapons have this?

code/modules/projectiles/guns/grenade_launchers.dm Outdated
@@ -222,7 +222,7 @@ The Grenade Launchers
fire_sound = 'sound/weapons/guns/fire/flare.ogg'
fire_sound = 'sound/weapons/guns/fire/flare.ogg'
w_class = WEIGHT_CLASS_SMALL
flags_gun_features = NONE
flags_gun_features = NONE|GUN_SMOKE_PARTICLES
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bruh

@Lumipharon Lumipharon added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Sep 18, 2023
comfyorange added a commit that referenced this pull request Sep 18, 2023
@comfyorange
TGS Test Merge (#13963)
7e76b26
@Lumipharon
Copy link
Contributor

It looks weird if you're shooting while moving, since the player sprite moves smoothly but the gun smoke will appear on their actual tile (i.e. the gun smoke will appear in front of you).

@AzonStarfall
Copy link
Contributor

Looks really nice, but how will this hold up stability-wise when we have 50+ marines on a highpop round all spraying additional particles? Would the effects be minimal?

@iforgotmeword
Copy link

is this server sided?
if yes: time dilation goes BRRRRRRRRRRRRRRR

@tyeagg
Copy link
Contributor Author

tyeagg commented Sep 19, 2023 •
edited
Loading

is this server sided? if yes: time dilation goes BRRRRRRRRRRRRRRR

particles are like the very few things that byond has rendered clientside and also multithread, the only thing server side is the objects that hold the particle

@lbnesquik
Copy link
Contributor

Test merge for performance

comfyorange added a commit that referenced this pull request Sep 20, 2023
@comfyorange
TGS Test Merge (#13963)
7af4980
comfyorange added a commit that referenced this pull request Sep 24, 2023
@comfyorange
TGS Test Merge (#13963)
83fac96
comfyorange added a commit that referenced this pull request Sep 24, 2023
@comfyorange
TGS Test Merge (#13963)
bb2d817
comfyorange added a commit that referenced this pull request Sep 24, 2023
@comfyorange
TGS Test Merge (#13963)
663846c
comfyorange added a commit that referenced this pull request Sep 24, 2023
@comfyorange
TGS Test Merge (#13963)
44a4fcf
comfyorange added a commit that referenced this pull request Sep 24, 2023
@comfyorange
TGS Test Merge (#13963)
b0cf033
comfyorange added a commit that referenced this pull request Sep 26, 2023
@comfyorange
TGS Test Merge (#13963)
3260eb5
comfyorange added a commit that referenced this pull request Sep 26, 2023
@comfyorange
TGS Test Merge (#13963)
9a5242e
comfyorange added a commit that referenced this pull request Sep 26, 2023
@comfyorange
TGS Test Merge (#13963)
40c7ec9
@tgstation-server tgstation-server removed the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Sep 26, 2023
@Lumipharon Lumipharon merged commit fd17e92 into tgstation:master Sep 26, 2023
github-actions bot added a commit that referenced this pull request Sep 26, 2023
@github-actions
Automatic changelog for PR #13963 [ci skip]
2efaf55
@ma44 ma44 mentioned this pull request Sep 27, 2023
Open
@QuacksQ QuacksQ mentioned this pull request Jan 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lumipharon Lumipharon Lumipharon requested changes

@TiviPlus TiviPlus TiviPlus approved these changes

@Kuro020 Kuro020 Kuro020 approved these changes

Assignees
No one assigned
Labels
Feature New interesting mechanics with new interesting bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@tyeagg @novaepee @yyzsong @Lumipharon @AzonStarfall @iforgotmeword @lbnesquik @Kuro020 @TiviPlus @tgstation-server