Update SV testfiles #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is unclear to me how the GitHub action jobs in #27 passed without error. Also, I normally run all tests before pushing. Still, it seems that some updated SV testfiles were likely be masked by a .gitignore file and not committed in #27. Or, the combination of the two merge requests #27 and #28 were not compatible. This oversight should have been caught by the GitHub action job. As it did not, here the remaining missing files.
|
@stefanlippuner yes, I thin you are right. I just arrived at the same conclusion and updated this PR's description accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The combination of the two merge requests #27 and #28 were not compatible. As the GitHub Action job runs only upon pushing, and the two merge request were shortly merged one after another, it was not detected. This PR updates the missing/outdated testfiles.