Add Skinny animation sample. #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rejurime
commented
May 29, 2023
rejurime
commented
- Add skinny animation sample.
- Add CustomPipelineManager to process animations content.
* Add skinny animation sample. * Add CustomPipelineManager to process animations content.
TGC.MonoGame.Samples/Animations/PipelineExtension/CustomPipelineManager.cs
Outdated
Show resolved
Hide resolved
AVinitzca
requested changes
Jun 27, 2023
| { | ||
| foreach (var bone in Bones) | ||
| { | ||
| if (bone.Name == name) |
There was a problem hiding this comment.
Esto va a buscar cada hueso por nombre. Podría estar en inicialización, pero cada vez que cambiás de animación va a ejecutarse y ya en el ejemplo de TGCito va a ejecutar ~70 veces este método. No podemos hacer esto por índice o algo similar?
| /// Animation Clip player. | ||
| /// It maps an animation Clip onto a Model. | ||
| /// </summary> | ||
| public class AnimationPlayer |
TGC.MonoGame.Samples/Animations/PipelineExtension/CustomPipelineManager.cs
Show resolved
Hide resolved
AVinitzca
reviewed
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.