Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAS 3.1 #825

Merged
merged 1 commit into from
Nov 30, 2023
Merged

OAS 3.1 #825

merged 1 commit into from
Nov 30, 2023

Conversation

tfranzel
Copy link
Owner

@tfranzel tfranzel commented Oct 2, 2022

WiP and preview of OAS 3.1 features. This is neither complete nor thoroughly tested but serves as a basis for discussion.

@johnthagen
Copy link
Contributor

Just for reference (I was curious myself) the following generators do not yet support OpenAPI 3.1:

Swagger UI (soon)?

The latest FastAPI generates a 3.0.2 schema.

@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (e022b4e) 98.62% compared to head (f66c70d) 98.58%.

❗ Current head f66c70d differs from pull request most recent head 28c0bc6. Consider uploading reports for the commit 28c0bc6 to get more accurate results

Files Patch % Lines
drf_spectacular/plumbing.py 83.33% 2 Missing ⚠️
drf_spectacular/hooks.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #825      +/-   ##
==========================================
- Coverage   98.62%   98.58%   -0.04%     
==========================================
  Files          70       70              
  Lines        8555     8581      +26     
==========================================
+ Hits         8437     8460      +23     
- Misses        118      121       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tfranzel tfranzel marked this pull request as ready for review November 30, 2023 01:02
@tfranzel tfranzel merged commit f31238e into master Nov 30, 2023
62 checks passed
@tfranzel tfranzel deleted the oas3.1 branch December 2, 2023 15:43
@mateokurti
Copy link

mateokurti commented Dec 18, 2023

Should this be reflected on #378 ? What about JSON Schema Draft 2020-12 ( #1071 )?

UPTADE: I just saw that fix confirmation pending label has been added to #1071. I guess this means that it should be implemented as well, but is waiting for some kind of confirmation?

UPDATE 2: Release 0.27.0 mentions the added support for OpenAPI 3.1, so I'm pretty sure it should be reflected on the issue. I'd assume that with OpenAPI 3.1, the support for JSON Schema comes as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants