-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add django rest framework mongoengine support #181
base: master
Are you sure you want to change the base?
Conversation
thanks for the PR. that is awesome! couple of things before i can really review it.
|
I will consider your terms. When the code is completed, I will notify you. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #181 +/- ##
==========================================
- Coverage 97.60% 96.84% -0.77%
==========================================
Files 49 50 +1
Lines 3672 3703 +31
==========================================
+ Hits 3584 3586 +2
- Misses 88 117 +29 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ngocngoan thanks! that looks so much better!
in order to merge this, we need to test the functionality. here is the test script i created when you first opened the issue, in order to check if this is even remotely working:
https://gist.github.com/tfranzel/c11382ea8e3801b701de0f4ef73fe0d5
feel free to adapt. basic functionality should be included.
django-filter>=2.3.0 | ||
pymongo>=3.11.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pymongo
is not required as it is a dependency of mongoengine
mongomock
will likely also come in handy for testing
MongoEngineAutoSchema
, which inherits from classAutoSchema
and is specified at the entryDEFAULT_SCHEMA_CLASS
in the configurationget_mongoengine_extended_doc_excludes
that compatible withmongoengine
, specify this function in the config