Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extend_schema_field with dict param and oas 3.1 #1147

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

codebutler
Copy link
Contributor

@codebutler codebutler commented Jan 18, 2024

the dict was being mutated, so every subsequent use of the field would have more stuff appended to the schema

without a fix, the test fails with this diff:

+++ 
@@ -42,12 +42,15 @@
           readOnly: true
         field2:
           type:
-          - string
+          - - string
+            - 'null'
           - 'null'
           readOnly: true
         field3:
           type:
-          - string
+          - - - string
+              - 'null'
+            - 'null'
           - 'null'
           readOnly: true
       required:

the dict was being mutated, so every subsequent use of the field would have more stuff appended to the schema
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.58%. Comparing base (aeca119) to head (6f3a656).
Report is 78 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1147      +/-   ##
==========================================
- Coverage   98.63%   98.58%   -0.05%     
==========================================
  Files          71       72       +1     
  Lines        8711     8782      +71     
==========================================
+ Hits         8592     8658      +66     
- Misses        119      124       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tfranzel tfranzel merged commit 6f3a656 into tfranzel:master Oct 3, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants