-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3.12 to test matrix and add classifiers #1096
Conversation
Seems they have already fixed it: jazzband/djangorestframework-simplejwt#754 |
After installing
|
Good question. I suppose the ecosystem is not there yet with 3.12 I have this issue on linux: https://stackoverflow.com/questions/77364550/attributeerror-module-pkgutil-has-no-attribute-impimporter-did-you-mean And on mac I have pip issues with installing So I couldn't even reproduce the issue here in the pipeline. |
looks like this is essentially only blocked by jazzband/djangorestframework-simplejwt#762 We have a bug in the except clause. It is missing JWTAuthentication = None
+ JWTTokenUserAuthentication = None then everything "works", except simplejwt and 2 other contrib libraries that have interdependent imports going on. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1096 +/- ##
=======================================
Coverage 98.58% 98.58%
=======================================
Files 68 68
Lines 8462 8462
=======================================
Hits 8342 8342
Misses 120 120 ☔ View full report in Codecov by Sentry. |
looks good to me. thx @foarsitter. though I'm a bit confused why simplejwt now passes for 3.12, given that they have not released and we didn't change much. I'll merge it. |
Thats indeed strange. There has to be a change in a underlying lib or something. Thanks for merging! |
djangorestframework-simplejwt
is not yet compatible with Python 3.12. Took me a while to figure out that the real errors gets silenced.drf-spectacular/tests/contrib/test_simplejwt.py
Lines 8 to 18 in 6e48a70
Is this is something acceptable in a different PR I'm happily to submit.